Skip to content

CgContext is not a data class!!! #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

@EgorkaKulikov EgorkaKulikov commented Apr 3, 2023

Description

This is a fix of awful bug.
CgContext was a data class containing many mutable variables, and it was used as a Map key in CgComponents.
So, method getVariableConstructorBy and others worked incorrectly.

Also fixes # (2060)

How to test

Automated tests

Full utbot-samples run verifies that there is no regression.

Manual tests

Scenario from issue.

Self-check list

Check off the item if the statement is true. Hint: [x] is a marked item.

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug labels Apr 3, 2023
@EgorkaKulikov EgorkaKulikov changed the title CgContext is not a data class!!! [draft] CgContext is not a data class!!! Apr 3, 2023
@EgorkaKulikov EgorkaKulikov changed the title [draft] CgContext is not a data class!!! CgContext is not a data class!!! Apr 3, 2023
@EgorkaKulikov EgorkaKulikov marked this pull request as draft April 3, 2023 15:58
@EgorkaKulikov EgorkaKulikov marked this pull request as ready for review April 3, 2023 16:07
@EgorkaKulikov EgorkaKulikov linked an issue Apr 4, 2023 that may be closed by this pull request
@EgorkaKulikov EgorkaKulikov merged commit be95266 into main Apr 4, 2023
@EgorkaKulikov EgorkaKulikov deleted the egor/cgcontext_is_not_a_data_class branch April 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing assertion is generated for Spring class
2 participants